[Backup] az backup container/item/policy/protection: Add support for ASE backup operations#31413
Merged
zhoxing-ms merged 41 commits intoAzure:devfrom May 19, 2025
Merged
Conversation
kumarutkarsh3b2166
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @kumarutkarsh3b2166, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup container re-register | cmd backup container re-register update parameter workload_type: updated property choices from ['MSSQL', 'SAPASE', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] to ['MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] |
||
| backup container register | cmd backup container register update parameter workload_type: updated property choices from ['MSSQL', 'SAPASE', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] to ['MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] |
||
| backup item list | cmd backup item list update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup item set-policy | cmd backup item set-policy update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup item show | cmd backup item show update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup policy create | cmd backup policy create update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup policy list | cmd backup policy list update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protectable-item initialize | cmd backup protectable-item initialize update parameter workload_type: updated property choices from ['MSSQL', 'SAPASE', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] to ['MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] |
||
| backup protectable-item list | cmd backup protectable-item list update parameter protectable_item_type: updated property choices from ['HANAInstance', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] to ['HANAInstance', 'SAPAseDatabase', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] |
||
| backup protectable-item list | cmd backup protectable-item list update parameter workload_type: updated property choices from ['MSSQL', 'SAPASE', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] to ['MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] |
||
| backup protectable-item show | cmd backup protectable-item show update parameter protectable_item_type: updated property choices from ['HANAInstance', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] to ['HANAInstance', 'SAPAseDatabase', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] |
||
| backup protectable-item show | cmd backup protectable-item show update parameter workload_type: updated property choices from ['MSSQL', 'SAPASE', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] to ['MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] |
||
| backup protection auto-disable-for-azurewl | cmd backup protection auto-disable-for-azurewl update parameter protectable_item_type: updated property choices from ['HANAInstance', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] to ['HANAInstance', 'SAPAseDatabase', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] |
||
| backup protection auto-disable-for-azurewl | cmd backup protection auto-disable-for-azurewl update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protection auto-enable-for-azurewl | cmd backup protection auto-enable-for-azurewl update parameter protectable_item_type: updated property choices from ['HANAInstance', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] to ['HANAInstance', 'SAPAseDatabase', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] |
||
| backup protection auto-enable-for-azurewl | cmd backup protection auto-enable-for-azurewl update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protection backup-now | cmd backup protection backup-now update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protection disable | cmd backup protection disable update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protection enable-for-azurewl | cmd backup protection enable-for-azurewl update parameter protectable_item_type: updated property choices from ['HANAInstance', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] to ['HANAInstance', 'SAPAseDatabase', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] |
||
| backup protection enable-for-azurewl | cmd backup protection enable-for-azurewl update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protection resume | cmd backup protection resume update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup protection undelete | cmd backup protection undelete update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup recoveryconfig show | cmd backup recoveryconfig show update parameter target_server_type: updated property choices from ['HANAInstance', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] to ['HANAInstance', 'SAPAseDatabase', 'SAPHanaDatabase', 'SAPHanaSystem', 'SQLAG', 'SQLDatabase', 'SQLInstance'] |
||
| backup recoveryconfig show | cmd backup recoveryconfig show update parameter workload_type: updated property choices from ['MSSQL', 'SAPASE', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] to ['MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase'] |
||
| backup recoverypoint list | cmd backup recoverypoint list update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup recoverypoint move | cmd backup recoverypoint move update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup recoverypoint show | cmd backup recoverypoint show update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
||
| backup recoverypoint show-log-chain | cmd backup recoverypoint show-log-chain update parameter workload_type: updated property choices from ['AzureFileShare', 'MSSQL', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] to ['AzureFileShare', 'MSSQL', 'SAPASE', 'SAPAseDatabase', 'SAPHANA', 'SAPHanaDatabase', 'SQLDataBase', 'VM'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
…umarutkarsh/postops
Contributor
Author
resolved |
zhoxing-ms
reviewed
May 13, 2025
Comment on lines
+970
to
+973
| # if item_type.lower() == "sapase": | ||
| # if log_point_in_time is not None: | ||
| # raise InvalidArgumentValueError('Integrated restore is not defined for log recovery point.') | ||
| # return AzureWorkloadSAPAseRestoreWithRehydrateRequest() |
Contributor
There was a problem hiding this comment.
Why add these code that has been commented?
zhoxing-ms
reviewed
May 13, 2025
| - name: Create a Windows VMSS with patch mode 'Manual' (Currently patch mode 'AutomaticByPlatform' is not supported during VMSS creation as health extension which is required for 'AutomaticByPlatform' mode cannot be set during VMSS creation). | ||
| text: > | ||
| az vmss create -n MyVmss -g MyResourceGroup --image Win2019Datacenter --enable-agent --enable-auto-update false --patch-mode Manual --orchestration-mode Flexible | ||
| az vmss create -n MyVmss -g MyResourceGroup --image Win2012R2Datacenter --enable-agent --enable-auto-update false --patch-mode Manual --orchestration-mode Flexible |
Contributor
There was a problem hiding this comment.
Suggested change
| az vmss create -n MyVmss -g MyResourceGroup --image Win2012R2Datacenter --enable-agent --enable-auto-update false --patch-mode Manual --orchestration-mode Flexible | |
| az vmss create -n MyVmss -g MyResourceGroup --image Win2022Datacenter --enable-agent --enable-auto-update false --patch-mode Manual --orchestration-mode Flexible |
Contributor
Author
There was a problem hiding this comment.
reverted changes in these files
zhoxing-ms
previously approved these changes
May 14, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
AllyW
approved these changes
May 19, 2025
zhoxing-ms
approved these changes
May 19, 2025
zhoxing-ms
changed the title
az backup container/item/policy/protection: Add cli support for ASE backup operationsaz backup container/item/policy/protection: Add support for ASE backup operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az backup container show
az backup container list
az backup item list
az backup item show
az backup policy show
az backup policy create
az backup policy delete
az backup item set-policy
az backup container register
az backup protection backup-now
az backup protection enable-for-azurewl
az backup protection backup-now
az backup recoverypoint list
az backup recoveryconfig show
az backup restore restore-azurewl
az backup protection disable
az backup container re-register
az backup container unregister
Description
This PR adds support for ASE workload operations for existing operations. This does not break any existing command and hence is not a breaking change.
Testing Guide
Added unit tests in tests_ase_commands.py
This checklist is used to make sure that common guidelines for a pull request are followed.
[*] The PR title and description has followed the guideline in Submitting Pull Requests.
[*] I adhere to the Command Guidelines.
[*] I adhere to the Error Handling Guidelines.